Fixed issues with configuring new GCE instances #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pgarg66
commented
Jul 10, 2018
pgarg66
commented
- New nodes cloned from a working node can be used with the script
- Script takes care of installing SSH keys, and package dependencies correctly
- New nodes cloned from a working node can be used with the script - Script takes care of installing SSH keys, and package dependencies correctly
garious
approved these changes
Jul 10, 2018
mvines
reviewed
Jul 10, 2018
multinode-demo/start_nodes.sh
Outdated
|
|
||
| ssh "$remote_user"@"$ip_addr" 'mkdir ~/.ssh' | ||
|
|
||
| ssh -n -f "$remote_user"@"$ip_addr" "sudo service sshguard stop" |
There was a problem hiding this comment.
Let's add a TODO comment here to avoid killing sshguard (filing an issue works too), as well as documenting why in a comment. For now this is ok, but in general we don't want to do be doing this IMO
mvines
reviewed
Jul 10, 2018
multinode-demo/start_nodes.sh
Outdated
| ssh -n -f "$remote_user"@"$ip_addr" "sudo service sshguard stop" | ||
| ssh -n -f "$remote_user"@"$ip_addr" 'sudo apt-get --assume-yes install rsync' | ||
|
|
||
| if [[ -n "$leader" ]]; then |
There was a problem hiding this comment.
@rob-solana is gonna tell you to remove those double quotes, [[ doesn't need them :)
mvines
reviewed
Jul 10, 2018
multinode-demo/start_nodes.sh
Outdated
|
|
||
| if [[ -n "$leader" ]]; then | ||
| echo "Adding known hosts for $ip_addr" | ||
| ssh -n -f "$remote_user"@"$ip_addr" "ssh-keygen -R $leader" |
There was a problem hiding this comment.
nit: "$remote_user@$ip_addr" seems nicer than "$remote_user"@"$ip_addr"
|
Addressing comments. Will push another patch after testing it. |
pgarg66
force-pushed
the
pankaj-remote-multinode-env
branch
from
33a16fa to
abe075a
Compare
|
@garious , I believe, this change can be merged. |
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
* Add Ristretto version of THEMIS BN BPF instruction counts: CalculateAggregate: 83,511 SubmitProofDecryption: 33,755,027 Ristretto BPF instruction counts: CalculateAggregate: 13,049,558 SubmitProofDecryption: 13,149,232 * Fix CI script
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Apr 4, 2024
…ee (solana-labs#566) * refactor shareble code into its own function; update and add tests * add function to reward with full prio fee and burnt transaction fee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.