Vet timestamp source from contract, not leader #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wrote this, but per https://github.com/solana-labs/solana#code-coverage, if it doesn't break a test, it's fair game to delete.
We had a test for this, but without `Bank::time_sources` (removed in the last commit), there's no last_time that can be trusted.
Per @aeyakovenko, contracts shouldn't trust the network for timestamps. Instead, pass the verified public key to the contract and let it decide if that's a public key it wants to trust the timestamp from. Fixes solana-labs#405
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
* Move interactions PublicKey to User constructor * Permit incremental interaction submissions * Split InitializePoliciesAccount into two instructions * Clean up BPF instruction count output * Update Themis program * Get submit_interactions() working on testnet * Fix build
carllin
pushed a commit
to carllin/solana
that referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #405 @carllin, can you please review?