Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build/deploy/start/stop to testnet setup scripts #560

Closed
wants to merge 1 commit into from

Conversation

pgarg66
Copy link
Contributor

@pgarg66 pgarg66 commented Jul 6, 2018

  • Source the script to add function to shell
  • Functions to build, deploy, start and stop multiple remote nodes

- Source the script to add function to shell
- Functions to build, deploy, start and stop multiple remote nodes
#!/bin/bash

usage() {
echo -e "\\tUsage: source this-script <IP Address array> <username> [path to ssh keys]\\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this form? https://github.com/solana-labs/solana/blob/master/multinode-demo/setup.sh#L7-L28

I also usually like my usage to exit for me, since 99.9% of the time the next command after usage is exit


if [[ "${BASH_SOURCE[0]}" == "${0}" ]]; then
echo -e "\\n\\tLooks like you are trying to run ${0}"
echo -e "\\tThe script must be sourced in your bash environment.\\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, why source?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see. Hmm, writing into my shell env is a little rude. Can this be avoided?

done
}

echo -e "\\tFollowing bash functions are available in your shell\\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My pref here is:

cat <<EOF
  blah
  blah
  blah
EOF

@garious
Copy link
Contributor

garious commented Jul 9, 2018

This PR is difficult to review because within a single commit, it renames the file while also changing its functionality. Also, the title of the PR doesn't state what functionality has been added or fixed, just " changed".

@garious garious changed the title Remote multinode script changes Add build/deploy/start/stop to testnet setup scripts Jul 9, 2018
@pgarg66 pgarg66 closed this Jul 10, 2018
@pgarg66 pgarg66 deleted the pankaj-remote-multinode-env branch July 10, 2018 00:45
vkomenda pushed a commit to vkomenda/solana that referenced this pull request Aug 29, 2021
* token-swap: Add slippage to swap / withdraw / deposit

* Update JS snake_case -> camelCase

* Run prettier
2501babe added a commit to 2501babe/solana that referenced this pull request May 13, 2024
program-runtime: modify sysvar cache impl

in prep for sol_sysvar_get, rework how SysvarCache stores data internally
we store account data directly, except also storing StakeHistory and SlotHashes as objects
these object representations can be removed after native programs are converted to bpf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants