-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build/deploy/start/stop to testnet setup scripts #560
Conversation
pgarg66
commented
Jul 6, 2018
- Source the script to add function to shell
- Functions to build, deploy, start and stop multiple remote nodes
- Source the script to add function to shell - Functions to build, deploy, start and stop multiple remote nodes
#!/bin/bash | ||
|
||
usage() { | ||
echo -e "\\tUsage: source this-script <IP Address array> <username> [path to ssh keys]\\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this form? https://github.com/solana-labs/solana/blob/master/multinode-demo/setup.sh#L7-L28
I also usually like my usage
to exit for me, since 99.9% of the time the next command after usage
is exit
|
||
if [[ "${BASH_SOURCE[0]}" == "${0}" ]]; then | ||
echo -e "\\n\\tLooks like you are trying to run ${0}" | ||
echo -e "\\tThe script must be sourced in your bash environment.\\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, why source
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see. Hmm, writing into my shell env is a little rude. Can this be avoided?
done | ||
} | ||
|
||
echo -e "\\tFollowing bash functions are available in your shell\\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My pref here is:
cat <<EOF
blah
blah
blah
EOF
This PR is difficult to review because within a single commit, it renames the file while also changing its functionality. Also, the title of the PR doesn't state what functionality has been added or fixed, just " changed". |
* token-swap: Add slippage to swap / withdraw / deposit * Update JS snake_case -> camelCase * Run prettier
program-runtime: modify sysvar cache impl in prep for sol_sysvar_get, rework how SysvarCache stores data internally we store account data directly, except also storing StakeHistory and SlotHashes as objects these object representations can be removed after native programs are converted to bpf