multinode-demo: Automatically add rsync:// prefix to URLs that need it #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob-solana
reviewed
Jun 27, 2018
| rsync_url() { # adds the 'rsync://` prefix to URLs that need it | ||
| local url="$1" | ||
|
|
||
| if [[ "$url" =~ ^.*:.*$ ]]; then |
There was a problem hiding this comment.
can do this more simply, if you like: ${url} != ${url%:*}
[rwalker@anodyne .ssh]$ hi=foothere
[rwalker@anodyne .ssh]$ [[ $hi != ${hi%:*} ]] && echo colon!
[rwalker@anodyne .ssh]$ hi=foo:there
[rwalker@anodyne .ssh]$ [[ $hi != ${hi%:*} ]] && echo colon!
colon!
There was a problem hiding this comment.
I think I prefer the existing form so imma keep it as is
rob-solana
reviewed
Jun 27, 2018
| @@ -47,3 +47,22 @@ export RUST_BACKTRACE=1 | |||
| [[ $(uname) = Linux ]] && (set -x; sudo sysctl -w net.core.rmem_max=26214400 1>/dev/null 2>/dev/null) | |||
|
|
|||
| SOLANA_CONFIG_DIR=${SNAP_DATA:-$PWD}/config | |||
|
|
|||
| rsync_url() { # adds the 'rsync://` prefix to URLs that need it | |||
| local url="$1" | |||
There was a problem hiding this comment.
I prefer declare over local, same meaning, can be used outside functions
|
:) |
Merged
CriesofCarrots
pushed a commit
that referenced
this pull request
Feb 28, 2020
* fix: add Account.rent_epoch field * fix: rebuild bpf test fixtures
mvines
added a commit
to mvines/solana
that referenced
this pull request
Jun 15, 2020
…ana-labs#466) * fix: add Account.rent_epoch field * fix: rebuild bpf test fixtures
mvines
added a commit
that referenced
this pull request
Jun 15, 2020
* fix: add Account.rent_epoch field * fix: rebuild bpf test fixtures
yihau
added a commit
to yihau/solana
that referenced
this pull request
Mar 29, 2024
willhickey
pushed a commit
that referenced
this pull request
Mar 29, 2024
ci: add release pipeline (#466) (cherry picked from commit 212cbdb) Co-authored-by: Yihau Chen <[email protected]>
willhickey
pushed a commit
that referenced
this pull request
Mar 29, 2024
ci: add release pipeline (#466) (cherry picked from commit 212cbdb) Co-authored-by: Yihau Chen <[email protected]>
t-nelson
pushed a commit
to t-nelson/solana
that referenced
this pull request
Apr 2, 2024
…-labs#486) ci: add release pipeline (solana-labs#466) (cherry picked from commit 212cbdb) Co-authored-by: Yihau Chen <[email protected]>
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Apr 7, 2024
…-labs#487) ci: add release pipeline (solana-labs#466) (cherry picked from commit 212cbdb) Co-authored-by: Yihau Chen <[email protected]>
HaoranYi
pushed a commit
to HaoranYi/solana
that referenced
this pull request
Apr 8, 2024
…-labs#486) ci: add release pipeline (solana-labs#466) (cherry picked from commit 212cbdb) Co-authored-by: Yihau Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things like this now work, which is much more ergonomic: