Filter out all unprocessed transactions before forwarding them #4266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4266 +/- ##
========================================
- Coverage 78.3% 77.3% -1.1%
========================================
Files 165 165
Lines 28783 29125 +342
========================================
- Hits 22555 22529 -26
- Misses 6228 6596 +368 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #4266 +/- ##
========================================
- Coverage 78.3% 77.3% -1.1%
========================================
Files 165 165
Lines 28783 29125 +342
========================================
- Hits 22555 22529 -26
- Misses 6228 6596 +368 |
sagar-solana
approved these changes
May 13, 2019
carllin
approved these changes
May 13, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Transactions with expired blockhash are getting forwarded.
Summary of Changes
The current code only filters out the batch of transactions that were being processed while the leader slot finished. All other transactions are getting blindly forwarded to the next leader node. This change deserializes all of the accumulated transactions in the node, and filters them before forwarding them.
This still leaves out the following scenario:
The client sends a transaction to a node which is not the leader. The node takes some time to process it thru its fetch/sigverify stage. By the time it reaches banking stage, it's expired (chances of this happening is very low). The node doesn't have a bank in banking stage, so it blindly forwards it to the next leader.