Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup entry #406

Merged
merged 3 commits into from
Jun 22, 2018
Merged

Cleanup entry #406

merged 3 commits into from
Jun 22, 2018

Conversation

garious
Copy link
Contributor

@garious garious commented Jun 21, 2018

No description provided.

@garious garious requested a review from rob-solana June 21, 2018 23:16
@rob-solana
Copy link
Contributor

lgtm. complicates my life a little with a merge ;)

@rob-solana
Copy link
Contributor

it occurs to me that next_hash() has 2 roles, which results in confusion on my part:

  • gimme the real next hash
  • hey, is this the next hash?

@garious garious merged commit fad9d20 into solana-labs:master Jun 22, 2018
@garious
Copy link
Contributor Author

garious commented Jun 22, 2018

Where is it being used as "hey, is this the next hash?" That's not the intent.

@rob-solana
Copy link
Contributor

verify()...

CriesofCarrots pushed a commit that referenced this pull request Feb 28, 2020
mvines pushed a commit to mvines/solana that referenced this pull request Jun 15, 2020
mvines pushed a commit that referenced this pull request Jun 15, 2020
godmodegalactus pushed a commit to blockworks-foundation/solana that referenced this pull request Jan 5, 2024
Use cluster info functions for tpu (solana-labs#345) (solana-labs#347)
Use git rev-parse for git sha
Remove blacklisted tx from message_hash_to_transaction (Backport solana-labs#374) (solana-labs#376)
Updates scripts for easy local setup. (solana-labs#383)
Backports sim_bundle improvements (solana-labs#407)
backports clone derivation 416 (solana-labs#417)
Backport solana-labs#419: add upsert to AccountOverrides (solana-labs#420)

backports solana-labs#430 v1.16: update jito-programs sha (solana-labs#431)

[JIT-1661] Faster Autosnapshot (solana-labs#406)

Fix Buildkite warnings (solana-labs#437)

Backport solana-labs#446 to v1.16 (solana-labs#447)

backport 428, runtime plugin (solana-labs#429)

v1.16: Backport solana-labs#449 (solana-labs#450)
lijunwangs pushed a commit to lijunwangs/solana that referenced this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants