Snap cuda fullnode #393
Merged
Snap cuda fullnode #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
reviewed
Jun 21, 2018
| source: https://solana-perf.s3.amazonaws.com/master/x86_64-unknown-linux-gnu/solana-perf.tgz | ||
| prime: | ||
| - solana-perf-HEAD.txt | ||
| solana-cuda: |
There was a problem hiding this comment.
Should this be named solana-perf?
snap/snapcraft.yaml
Outdated
| @@ -29,6 +34,44 @@ apps: | |||
| command: solana-mint-demo | |||
|
|
|||
| parts: | |||
| solana-perf: | |||
There was a problem hiding this comment.
Should this be named something like solana-perf-tarball?
snap/snapcraft.yaml
Outdated
|
|
||
| apps: | ||
| cuda-fullnode: | ||
| command: solana-cuda-fullnode |
There was a problem hiding this comment.
How about the name solana-fullnode-perf?
Codecov Report
@@ Coverage Diff @@
## master #393 +/- ##
==========================================
+ Coverage 90.81% 90.88% +0.07%
==========================================
Files 36 36
Lines 3526 3523 -3
==========================================
Hits 3202 3202
+ Misses 324 321 -3
Continue to review full report at Codecov.
|
garious
approved these changes
Jun 21, 2018
|
💔 Unable to automerge due to CI failure |
solana-grimes
removed
the
automerge
mvines
added
automerge
|
💔 Unable to automerge due to CI failure |
solana-grimes
removed
the
automerge
This is necessary until we build a docker image that also contains a CUDA installation
|
💔 Unable to automerge due to CI failure |
solana-grimes
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #372