Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generic_array #379

Merged
merged 1 commit into from
Jun 20, 2018
Merged

Conversation

garious
Copy link
Contributor

@garious garious commented Jun 19, 2018

Warning: this may have performance implications.

@garious garious requested a review from sakridge June 19, 2018 00:29
Warning: this may have performance implications.
@garious garious force-pushed the update-generic-array branch from 3f91b0c to 3284eca Compare June 19, 2018 13:37
@codecov
Copy link

codecov bot commented Jun 19, 2018

Codecov Report

Merging #379 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #379   +/-   ##
=======================================
  Coverage   90.78%   90.78%           
=======================================
  Files          36       36           
  Lines        3493     3493           
=======================================
  Hits         3171     3171           
  Misses        322      322
Impacted Files Coverage Δ
src/hash.rs 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75997e6...3284eca. Read the comment docs.

@sakridge
Copy link
Member

@garious I tried it on p2.xlarge with the client demo with didn't seem to make any significant performance difference.

@garious
Copy link
Contributor Author

garious commented Jun 20, 2018

Thanks @sakridge! will merge it.

@garious garious merged commit 410272e into solana-labs:master Jun 20, 2018
vkomenda pushed a commit to vkomenda/solana that referenced this pull request Aug 29, 2021
* Fixup spl-token docs

* Apply suggestions from code review

Co-authored-by: Michael Vines <[email protected]>

Co-authored-by: Michael Vines <[email protected]>
buffalojoec pushed a commit to buffalojoec/solana that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants