Issue #336: added retransmission of repair messages #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgarg66
reviewed
Jun 18, 2018
src/crdt.rs
Outdated
| num_retransmits != 0 && | ||
| !num_retransmits.is_power_of_two() | ||
| { | ||
| return None; |
There was a problem hiding this comment.
If it's not power of two, shouldn't we transmit with id of receiver (the original logic)?
There was a problem hiding this comment.
Cool, while at it, could you fix the code formatting error (causing CI failure)
There was a problem hiding this comment.
Hm, I misunderstood this part of the original issue. Even if the goal is to reduce network congestion among the validators, it still does make more sense to just respond with a response, but not rebroadcast, on non-power of two requests. Good point!
There was a problem hiding this comment.
Sure, done and done :)
|
See #382 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#336