Improve banking_stage performance messages #3694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use transaction count instead of batch count, and set the recv_start from when we finished processing the previous batch to get a more accurate number.
Codecov Report
@@ Coverage Diff @@
## master #3694 +/- ##
========================================
+ Coverage 79.6% 79.6% +<.1%
========================================
Files 155 155
Lines 24930 24932 +2
========================================
+ Hits 19854 19858 +4
+ Misses 5076 5074 -2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
banking_stage perf messages not accurate since being able to process a portion of a batch and recv_start is not reset from the start of message recv.
Summary of Changes
Use transaction count instead of batch count,
and set the recv_start from when we finished processing
the previous batch to get a more accurate number.
Fixes #