Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.17: blockstore: atomize slot clearing, relax parent slot meta check (backport of #35124) #35408

Closed
wants to merge 1 commit into from

Commits on Mar 3, 2024

  1. blockstore: atomize slot clearing, relax parent slot meta check (#35124)

    * blockstore: atomize slot clearing, relax parent slot meta check
    
    clear_unconfirmed_slot can leave blockstore in an irrecoverable state
    if it panics in the middle. write batch this function, so that any
    errors can be recovered after restart.
    
    additionally relax the constraint that the parent slot meta must exist,
    as it could have been cleaned up if outdated.
    
    * pr feedback: use PurgeType, don't pass slot_meta
    
    * pr feedback: add unit test
    
    * pr feedback: refactor into separate function
    
    * pr feedback: add special columns to helper, err msg, comments
    
    * pr feedback: reword comments and write batch error message
    
    * pr feedback: bubble write_batch error to caller
    
    * pr feedback: reword comments
    
    Co-authored-by: steviez <[email protected]>
    
    ---------
    
    Co-authored-by: steviez <[email protected]>
    (cherry picked from commit cc4072b)
    
    # Conflicts:
    #	ledger/src/blockstore.rs
    #	ledger/src/blockstore/blockstore_purge.rs
    AshwinSekar authored and mergify[bot] committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    116d008 View commit details
    Browse the repository at this point in the history