Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip link_local v4 addresses and v6 address when v6 is not enabled #354

Merged
merged 1 commit into from
Jun 14, 2018

Conversation

sakridge
Copy link
Member

No description provided.

@sakridge sakridge force-pushed the better_network_config branch from 18c179a to f223760 Compare June 14, 2018 18:41
@sakridge sakridge force-pushed the better_network_config branch from f223760 to f2f267a Compare June 14, 2018 18:55
@codecov
Copy link

codecov bot commented Jun 14, 2018

Codecov Report

Merging #354 into master will decrease coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
- Coverage   90.58%   90.48%   -0.11%     
==========================================
  Files          36       36              
  Lines        3411     3415       +4     
==========================================
  Hits         3090     3090              
- Misses        321      325       +4
Impacted Files Coverage Δ
src/crdt.rs 82.86% <0%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec713c1...f2f267a. Read the comment docs.

@garious garious requested a review from rob-solana June 14, 2018 20:26
@rob-solana
Copy link
Contributor

This change looks to have got me off link-local, thanks! Until I did a re-generation of leader.json, I remained stuck.

@garious
Copy link
Contributor

garious commented Jun 14, 2018

Good to know about that caveat. Thanks Rob!

@garious garious merged commit 8b9713a into solana-labs:master Jun 14, 2018
vkomenda pushed a commit to vkomenda/solana that referenced this pull request Aug 29, 2021
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Apr 1, 2024
The IP echo server currently spins up a worker thread for every thread
on the machine. Observing some data for nodes,
- MNB validators and RPC nodes look to get several hundred of these
  requests per day
- MNB entrypoint nodes look to get 2-3 requests per second on average

In both instances, the current threadpool is severely overprovisioned
which is a waste of resources. This PR plumnbs a flag to control the
number of worker threads for this pool as well as setting a default of
two threads for this server. Two threads allow for one thread to always
listen on the TCP port while the other thread processes requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants