Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.18: [clap-v3-utils] Add functions to parse directly from SignerSource (backport of #34678) #35384

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 29, 2024

This is an automatic backport of pull request #34678 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…34678)

* add `_from_source` function variants for signer, keypair, and pubkey

* make `parse_signer_source` an associated function of `SignerSource`

* refactor `SignerSource` into `input_parsers::signer`

* make `_from_source` functions public

* remove unnecessary import

(cherry picked from commit 3004eaa)
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 56.77083% with 83 lines in your changes are missing coverage. Please review.

Project coverage is 81.6%. Comparing base (e302417) to head (30f51c6).
Report is 4 commits behind head on v1.18.

Additional details and impacted files
@@            Coverage Diff            @@
##            v1.18   #35384     +/-   ##
=========================================
- Coverage    81.6%    81.6%   -0.1%     
=========================================
  Files         827      827             
  Lines      224160   224288    +128     
=========================================
+ Hits       183006   183051     +45     
- Misses      41154    41237     +83     

@samkim-crypto samkim-crypto merged commit 994e81e into v1.18 Mar 1, 2024
35 checks passed
@samkim-crypto samkim-crypto deleted the mergify/bp/v1.18/pr-34678 branch March 1, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants