Remove unnecessary unwrap from simulate_transaction_unchecked()

[pgarg66]

Problem

simulate_transaction_unchecked() does unnecessary unwrap(), that can be handled more gracefully.

Summary of Changes

Replace unwrap() with better handling.

Fixes #

[t-nelson]

i guess this is about as generic a TransactionError as we have 🤔

prolly fine for now since this is isolated to simulation

[pgarg66]

Yeah, the other one we could use was AccountInUse. Nothing generic otherwise.

[Lichtso]

Does TransactionExecutionResult::NotExecuted trigger a replay?

[t-nelson]

assuming by "replay" you mean that the tx is retryable, no. when a tx makes it to execute, it's getting fees taken and committed in a block. even if it were, this logic is in simulate, which won't be committed anyway

[Lichtso]

I meant retryable yes. And I forgot that this is simulation and thus a failure is not repeated. So seems alright to me.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.7%. Comparing base (6ee3bb9) to head (7a1c830).
Report is 21 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #35375    +/-   ##
========================================
  Coverage    81.7%    81.7%            
========================================
  Files         834      834            
  Lines      224299   224819   +520     
========================================
+ Hits       183361   183831   +470     
- Misses      40938    40988    +50     

[t-nelson]

-2 unwrap()s! 🥳

[mergify]

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

[mergify]

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.