Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes ouroboros dependency #35355

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

brooksprumo
Copy link
Contributor

@brooksprumo brooksprumo commented Feb 28, 2024

Problem

The ouroboros dependency is no longer used in accounts-db (or anywhere!), and we probably do not want to add new self-referential structs if possible.

Summary of Changes

Remove it.

@brooksprumo brooksprumo added the work in progress This isn't quite right yet label Feb 28, 2024
@brooksprumo brooksprumo self-assigned this Feb 28, 2024
@CriesofCarrots
Copy link
Contributor

I think accounts-db was the only ouroboros user...? The crate is listed in the runtime Cargo.toml, but I don't see it imported anywhere. Maybe we can remove the dependency from the workspace?

@brooksprumo
Copy link
Contributor Author

I think accounts-db was the only ouroboros user...? The crate is listed in the runtime Cargo.toml, but I don't see it imported anywhere. Maybe we can remove the dependency from the workspace?

Will do!

@brooksprumo brooksprumo changed the title Removes ouroboros from accounts-db dependencies Removes ouroboros dependency Feb 28, 2024
@brooksprumo brooksprumo removed the work in progress This isn't quite right yet label Feb 28, 2024
@brooksprumo brooksprumo marked this pull request as ready for review February 28, 2024 21:31
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.8%. Comparing base (6ee3bb9) to head (c6656dd).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #35355    +/-   ##
========================================
  Coverage    81.7%    81.8%            
========================================
  Files         834      834            
  Lines      224299   224834   +535     
========================================
+ Hits       183361   183918   +557     
+ Misses      40938    40916    -22     

Copy link
Contributor

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brooksprumo brooksprumo merged commit 9146236 into solana-labs:master Feb 28, 2024
47 checks passed
@brooksprumo brooksprumo deleted the self-ref/remove-ouroboros branch February 28, 2024 22:58
wen-coding added a commit to wen-coding/solana that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants