-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes ouroboros dependency #35355
Removes ouroboros dependency #35355
Conversation
I think accounts-db was the only ouroboros user...? The crate is listed in the runtime Cargo.toml, but I don't see it imported anywhere. Maybe we can remove the dependency from the workspace? |
Will do! |
0ed47f1
to
c6656dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35355 +/- ##
========================================
Coverage 81.7% 81.8%
========================================
Files 834 834
Lines 224299 224834 +535
========================================
+ Hits 183361 183918 +557
+ Misses 40938 40916 -22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This reverts commit 9146236.
Problem
The
ouroboros
dependency is no longer used in accounts-db (or anywhere!), and we probably do not want to add new self-referential structs if possible.Summary of Changes
Remove it.