Refactor - Move recompilation out of program loading #35297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
|
Do we need to backport this to v1.18? |
Lichtso
force-pushed
the
refactor/recompilation_out_of_program_loading
branch
from
f64b72a to
34a2820
Compare
pgarg66
approved these changes
Feb 23, 2024
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Feb 27, 2024
Moves recompilation specifics out of load_program().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The adjustments for programs being loaded in the recompilation phase can be done at the caller (
Bank::_new_from_parent()) and don't need to pollute the callee (TransactionBatchProcessor::load_program()).This PR was split from #35283 which should land first.
Summary of Changes
Moves the setting of
effective_epoch,tx_usage_counterandix_usage_counterfrom the callee to the caller.