Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler inner metrics #35271

Merged
merged 1 commit into from
Feb 22, 2024
Merged

scheduler inner metrics #35271

merged 1 commit into from
Feb 22, 2024

Conversation

apfitzge
Copy link
Contributor

Problem

Another split out of #35087.

Summary of Changes

  • Create inner structs for scheduler counts and timings
  • Wrap inner structs with interval-reported structs which impl Deref & DerefMut for easy field access
  • These inner structs will be re-used for reporting on slot-level in Scheduler: Leader-Slot metrics for Scheduler #35087

Fixes #

@apfitzge apfitzge force-pushed the scheduler_metrics_inner branch from e2a6025 to 42bfc11 Compare February 21, 2024 17:33
@apfitzge apfitzge requested a review from tao-stones February 22, 2024 05:22
@apfitzge apfitzge marked this pull request as ready for review February 22, 2024 05:22
tao-stones
tao-stones approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@apfitzge apfitzge merged commit 367f489 into solana-labs:master Feb 22, 2024
35 checks passed
@apfitzge apfitzge deleted the scheduler_metrics_inner branch February 22, 2024 23:01
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Feb 27, 2024
@apfitzge @jeffwashington
scheduler inner metrics (solana-labs#35271)
f773235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao-stones tao-stones tao-stones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apfitzge @tao-stones