-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List the default value for --accounts
in CLI help
#35254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wanna fix this issue in |
Yes, how could I forget about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Can you update the PR's title too? Maybe just remove the word "validator'?
--accounts
in CLI help
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35254 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 833 833
Lines 224760 224760
=======================================
+ Hits 183452 183486 +34
+ Misses 41308 41274 -34 |
Problem
--accounts
is not a required argument, so list what the default location is if unspecified. We do this for several others similar arguments.