Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build transfer hook for downstream project #35245

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Build transfer hook for downstream project #35245

merged 2 commits into from
Feb 21, 2024

Conversation

LucasSte
Copy link
Contributor

Problem

When running ci/downstream-projects/func-spl.sh, the binary for spl_transfer_hook_example.so is missing and we get the error:

---- test::test_create stdout ----
thread 'test::test_create' panicked at /Users/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/solana-program-test-1.17.17/src/lib.rs:451:31:
Failed to open "../../../target/deploy/spl_transfer_hook_example.so": No such file or directory (os error 2)

Summary of Changes

I added a command to build the aforementioned binary.

@LucasSte LucasSte requested review from joncinque and yihau February 19, 2024 18:52
@LucasSte LucasSte marked this pull request as ready for review February 19, 2024 20:17
@yihau
Copy link
Member

yihau commented Feb 20, 2024

looks good to me! but I defer to Jon. need his insight here.

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this script is really used anymore, but rather than add it as a separate step, how about adding token/transfer-hook/example to the list of programs to run test-sbf on? You can add it after instruction-padding/program on line 7.

@LucasSte
Copy link
Contributor Author

I don't think this script is really used anymore, but rather than add it as a separate step, how about adding token/transfer-hook/example to the list of programs to run test-sbf on? You can add it after instruction-padding/program on line 7.

Thanks for your review. I'll implement your suggestion.

This script is still useful for verifying the integration between the compiler toolchain and the virtual machine, as it compiles and runs a bunch of SBF programs.

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@LucasSte LucasSte merged commit a97f26e into solana-labs:master Feb 21, 2024
16 checks passed
@LucasSte LucasSte deleted the fix-script branch February 21, 2024 17:21
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Feb 27, 2024
* Build transfer hook for downstream project

* Add transfer hook example to programs list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants