Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes get_account_read_entry_with_lock() #35240

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

brooksprumo
Copy link
Contributor

@brooksprumo brooksprumo commented Feb 19, 2024

Problem

See #34786 for background.

We want to limit the use of ReadAccountMapEntry, from AccountsIndex, everywhere. Ultimately removing it once there are no more uses.

We want to remove get_account_read_entry_with_lock(), and it is only used by get_account_read_entry(), so the separate function can be removed.

Summary of Changes

Removes get_account_read_entry_with_lock() and inlines the impl into get_account_read_entry()

@brooksprumo brooksprumo added the work in progress This isn't quite right yet label Feb 19, 2024
@brooksprumo brooksprumo self-assigned this Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d87e7bc) 81.6% compared to head (c8b430a) 81.6%.
Report is 11 commits behind head on master.

❗ Current head c8b430a differs from pull request most recent head 811b986. Consider uploading reports for the commit 811b986 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #35240   +/-   ##
=======================================
  Coverage    81.6%    81.6%           
=======================================
  Files         833      833           
  Lines      224768   224760    -8     
=======================================
+ Hits       183475   183489   +14     
+ Misses      41293    41271   -22     

@brooksprumo brooksprumo removed the work in progress This isn't quite right yet label Feb 20, 2024
@brooksprumo brooksprumo marked this pull request as ready for review February 20, 2024 18:58
Copy link
Contributor

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@brooksprumo brooksprumo merged commit db2071a into solana-labs:master Feb 21, 2024
36 checks passed
@brooksprumo brooksprumo deleted the self-ref/3/index/2 branch February 21, 2024 16:25
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants