This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Replaces ReadAccountMapEntry in snapshot minimizer #35237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
force-pushed
the
self-ref/2/snapshot-minimizer
branch
from
1f5a75e to
976d326
Compare
brooksprumo
changed the title
|
@apfitzge Requesting your review because I'm touching the snapshot minimizer code |
apfitzge
approved these changes
Feb 19, 2024
Comment on lines
+265
to
+266
| .read() | ||
| .unwrap() |
There was a problem hiding this comment.
Note: previously the ReadAccountMapEntry held this lock internally, so no added contention here.
should also be saving on the removed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #34786 for background.
We want to limit the use of
ReadAccountMapEntry, from AccountsIndex, everywhere. Ultimately removing it once there are no more uses.When creating a minimized snapshot we query the Accounts Index to find which pubkeys are used, and in which slots. The impl currently uses
ReadAccountMapEntry, but can be rewritten to avoid it.Summary of Changes
Replaces
get_account_read_entry()in snapshot minimizer.