Cleanup - disable_bpf_loader_instructions
#35164
Merged
+78
−503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
cleanup/disable_bpf_loader_instructions
branch
2 times, most recently
from
3021fd4 to
d90155c
Compare
HaoranYi
force-pushed
the
cleanup/disable_bpf_loader_instructions
branch
2 times, most recently
from
464141f to
f3042ee
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #35164 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.1%
=========================================
Files 833 833
Lines 224827 224744 -83
=========================================
- Hits 183523 183435 -88
- Misses 41304 41309 +5 |
|
@Lichtso I pushed a few commits to update the test and bench. CI passed. I think this PR is ready. Can you take a look? |
HaoranYi
force-pushed
the
cleanup/disable_bpf_loader_instructions
branch
from
5f8e830 to
c8709df
Compare
alessandrod
reviewed
Feb 14, 2024
alessandrod
reviewed
Feb 14, 2024
HaoranYi
force-pushed
the
cleanup/disable_bpf_loader_instructions
branch
2 times, most recently
from
c6d9ca4 to
a01bdbd
Compare
This reverts commit f3042ee.
alessandrod
force-pushed
the
cleanup/disable_bpf_loader_instructions
branch
from
a01bdbd to
86b48a6
Compare
alessandrod
approved these changes
Feb 15, 2024
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
mergify bot
pushed a commit
that referenced
this pull request
Feb 15, 2024
* Cleans up disable_bpf_loader_instructions. * fix test_program_sbf_disguised_as_sbf_loader * remove bpf loader execute bench * Revert "remove bpf loader execute bench" This reverts commit f3042ee. * move test utility functions out of test file * update bench to loader v3 * clippy * fix dev-context build * fix dev-context import * dev-context-util * move dev-context-util attr to module level for loader_utils --------- Co-authored-by: HaoranYi <[email protected]> (cherry picked from commit d472725) # Conflicts: # programs/bpf_loader/src/lib.rs
Lichtso
added a commit
that referenced
this pull request
Feb 15, 2024
* Cleans up disable_bpf_loader_instructions. * fix test_program_sbf_disguised_as_sbf_loader * remove bpf loader execute bench * Revert "remove bpf loader execute bench" This reverts commit f3042ee. * move test utility functions out of test file * update bench to loader v3 * clippy * fix dev-context build * fix dev-context import * dev-context-util * move dev-context-util attr to module level for loader_utils --------- Co-authored-by: HaoranYi <[email protected]> (cherry picked from commit d472725)
Lichtso
added a commit
that referenced
this pull request
Feb 16, 2024
… (#35209) Cleanup - `disable_bpf_loader_instructions` (#35164) * Cleans up disable_bpf_loader_instructions. * fix test_program_sbf_disguised_as_sbf_loader * remove bpf loader execute bench * Revert "remove bpf loader execute bench" This reverts commit f3042ee. * move test utility functions out of test file * update bench to loader v3 * clippy * fix dev-context build * fix dev-context import * dev-context-util * move dev-context-util attr to module level for loader_utils --------- Co-authored-by: HaoranYi <[email protected]> (cherry picked from commit d472725) Co-authored-by: Alexander Meißner <[email protected]>
andreisilviudragnea
added a commit
to andreisilviudragnea/solana-test-framework
that referenced
this pull request
Aug 14, 2024
andreisilviudragnea
added a commit
to andreisilviudragnea/solana-test-framework
that referenced
this pull request
Aug 14, 2024
Replace bpf_loader::id() with bpf_loader_upgradeable::id()
andreisilviudragnea
added a commit
to andreisilviudragnea/solana-test-framework
that referenced
this pull request
Aug 14, 2024
Replace bpf_loader::id() with bpf_loader_upgradeable::id()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The feature was forced in v1.17.20 on MNB.
Summary of Changes
Removes it from master and v1.18 as well to stay in sync.
Feature Gate Issue: #34424