Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validator: include waited_for_supermajority in startup metric #35137

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

AshwinSekar
Copy link
Contributor

@AshwinSekar AshwinSekar commented Feb 7, 2024

useful to determine whether the shred version cleanup logic in blockstore was performed.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (bc735fa) 81.6% compared to head (878a2ce) 81.6%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #35137     +/-   ##
=========================================
- Coverage    81.6%    81.6%   -0.1%     
=========================================
  Files         832      832             
  Lines      224834   224842      +8     
=========================================
- Hits       183589   183543     -46     
- Misses      41245    41299     +54     

@AshwinSekar AshwinSekar requested a review from t-nelson February 20, 2024 04:34
core/src/validator.rs Show resolved Hide resolved
@AshwinSekar AshwinSekar merged commit b0134ab into solana-labs:master Feb 21, 2024
35 checks passed
@AshwinSekar AshwinSekar added v1.17 PRs that should be backported to v1.17 v1.18 PRs that should be backported to v1.18 labels Feb 21, 2024
Copy link
Contributor

mergify bot commented Feb 21, 2024

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

Copy link
Contributor

mergify bot commented Feb 21, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Feb 21, 2024
(cherry picked from commit b0134ab)

# Conflicts:
#	core/src/validator.rs
mergify bot pushed a commit that referenced this pull request Feb 21, 2024
mergify bot added a commit that referenced this pull request Feb 21, 2024
…(backport of #35137) (#35277)

validator: include waited_for_supermajority in startup metric (#35137)

(cherry picked from commit b0134ab)

Co-authored-by: Ashwin Sekar <[email protected]>
AshwinSekar added a commit that referenced this pull request Feb 22, 2024
…(backport of #35137) (#35276)

* validator: include waited_for_supermajority in startup metric (#35137)

(cherry picked from commit b0134ab)

# Conflicts:
#	core/src/validator.rs

* fix conflicts

---------

Co-authored-by: Ashwin Sekar <[email protected]>
jeffwashington pushed a commit to jeffwashington/solana that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.17 PRs that should be backported to v1.17 v1.18 PRs that should be backported to v1.18
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants