Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.18: sdk: add Immutable and IncorrectAuthority to ProgramError (backport of #35113) #35136

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 7, 2024

This is an automatic backport of pull request #35113 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (863cfad) 81.6% compared to head (98444cd) 81.6%.

Additional details and impacted files
@@            Coverage Diff            @@
##            v1.18   #35136     +/-   ##
=========================================
- Coverage    81.6%    81.6%   -0.1%     
=========================================
  Files         827      827             
  Lines      223997   224005      +8     
=========================================
- Hits       182942   182902     -40     
- Misses      41055    41103     +48     

@CriesofCarrots
Copy link
Contributor

In the interest of process, please make the case why this should be backported. Thanks!

@buffalojoec
Copy link
Contributor

In the interest of process, please make the case why this should be backported. Thanks!

Also in the interest of process, and considering the recent discussions around backporting, I'll close this backport PR.

The intention was to shortcut availability of these errors, considering the extremely low diff, however I'd rather follow the rules.

@mergify mergify bot deleted the mergify/bp/v1.18/pr-35113 branch February 15, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants