Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ability to submit metrics with no fields #35133

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

apfitzge
Copy link
Contributor

@apfitzge apfitzge commented Feb 7, 2024

Problem

#35132

Summary of Changes

  • Remove ability to submit fieldless datapoints via macros
  • Remove attempts to submit fieldless datapoints via macros

Fixes #35132

@apfitzge apfitzge force-pushed the no-fieldless-datapoints branch from a221ea5 to 94a0f91 Compare February 7, 2024 19:41
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc735fa) 81.6% compared to head (94a0f91) 81.6%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #35133     +/-   ##
=========================================
- Coverage    81.6%    81.6%   -0.1%     
=========================================
  Files         832      832             
  Lines      224834   224833      -1     
=========================================
- Hits       183589   183503     -86     
- Misses      41245    41330     +85     

Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

@apfitzge apfitzge merged commit 2a9ed3e into solana-labs:master Feb 16, 2024
35 checks passed
@apfitzge apfitzge deleted the no-fieldless-datapoints branch February 16, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InfluxDB does not support datapoints without fields
2 participants