Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed atty library #351

Merged
merged 2 commits into from
Jun 14, 2018
Merged

changed atty library #351

merged 2 commits into from
Jun 14, 2018

Conversation

rlkelly
Copy link
Contributor

@rlkelly rlkelly commented Jun 13, 2018 •
edited by garious
Loading

Fixes #340

@garious garious added CI Pull Request is ready to enter CI automerge Merge this Pull Request automatically once CI passes labels Jun 13, 2018
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Jun 13, 2018
@garious
Copy link
Contributor

garious commented Jun 13, 2018

@rob-solana, fyi

@solana-grimes solana-grimes removed the automerge Merge this Pull Request automatically once CI passes label Jun 13, 2018
@solana-grimes
Copy link
Contributor

💔 Unable to automerge due to CI failure

1 similar comment
@solana-grimes
Copy link
Contributor

💔 Unable to automerge due to CI failure

@solana-grimes solana-grimes removed the automerge Merge this Pull Request automatically once CI passes label Jun 13, 2018
@garious
Copy link
Contributor

garious commented Jun 13, 2018

Can you run cargo fmt from rust 1.26.2 (latest stable)?

@rlkelly
Copy link
Contributor Author

rlkelly commented Jun 14, 2018

sure thing

@codecov
Copy link

codecov bot commented Jun 14, 2018 •
edited
Loading

Codecov Report

Merging #351 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #351   +/-   ##
======================================
  Coverage    91.4%   91.4%           
======================================
  Files          34      34           
  Lines        3375    3375           
======================================
  Hits         3085    3085           
  Misses        290     290

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d3b052...2ea65eb. Read the comment docs.

@garious garious added CI Pull Request is ready to enter CI automerge Merge this Pull Request automatically once CI passes labels Jun 14, 2018
@solana-grimes solana-grimes removed CI Pull Request is ready to enter CI labels Jun 14, 2018
@garious garious added the CI Pull Request is ready to enter CI label Jun 14, 2018
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Jun 14, 2018
@solana-grimes solana-grimes merged commit 34e0cb0 into solana-labs:master Jun 14, 2018
@adamlaska adamlaska mentioned this pull request Nov 17, 2023
Open
@adamlaska adamlaska mentioned this pull request Dec 28, 2023
Open
@adamlaska adamlaska mentioned this pull request Jan 5, 2024
Open
lijunwangs pushed a commit to lijunwangs/solana that referenced this pull request Mar 21, 2024
@mergify @yihau
v1.17: [anza migration]: fix download link for net scripts (backport of
11d4156 
solana-labs#219) (solana-labs#351)

* [anza migration]: fix download link for net scripts (solana-labs#219)

(cherry picked from commit e682fec)

# Conflicts:
#	net/net.sh
#	scripts/agave-install-deploy.sh

* fix conflict

---------

Co-authored-by: Yihau Chen <[email protected]>
Co-authored-by: yihau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rlkelly @garious @solana-grimes