update rent epoch max test #35092
Merged
update rent epoch max test #35092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
4fb2
branch
2 times, most recently
from
54e0658 to
23b8f04
Compare
HaoranYi
reviewed
Feb 5, 2024
runtime/src/bank/tests.rs
Outdated
| "4uX1AZFbqwjwWBACWbAW3V8rjbWH4N3ZRTbNysSLAzj2" | ||
| ); | ||
| break; | ||
| if set_rent_epoch_max { |
There was a problem hiding this comment.
maybe invert the if condition, so that the diff is clearer.
brooksprumo
approved these changes
Feb 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35092 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 830 830
Lines 225019 225035 +16
=======================================
+ Hits 183675 183705 +30
+ Misses 41344 41330 -14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
feature
set_exempt_rent_epoch_maxwas activated.Updating hashes on a test is dangerous. it is easy to miss an unintentional change.
Summary of Changes
Modify a bank hash test to prepare to remove the code behind the feature change. This way the contents are known and the hashes will match. #35082 will be easier to verify as correct.
Fixes #