Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger-tool: Change --snapshot-archive-path to --snapshots #35019

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

steviez
Copy link
Contributor

@steviez steviez commented Jan 30, 2024

Summary of Changes

This change makes solana-ledger-tool match solana-validator CLI; the old
flag --snapshot-archive-path is retained as an argument alias and can
still be used for the sake of backwards compatibility.

solana/validator/src/cli.rs

Lines 296 to 302 in 0dcac3f

.arg(
Arg::with_name("snapshots")
.long("snapshots")
.value_name("DIR")
.takes_value(true)
.help("Use DIR as snapshot location [default: --ledger value]"),
)

Possibly more work to be done to deduplicate the arguments between validator and ledger-tool, but I think that is for another day.

This change makes solana-ledger-tool match solana-validator CLI; the old
flag --snapshot-archive-path is retained as an argument alias and can
still be used for the sake of backwards compatibility.
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c6c2340) 81.6% compared to head (bf5f4ea) 81.6%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #35019     +/-   ##
=========================================
- Coverage    81.6%    81.6%   -0.1%     
=========================================
  Files         830      830             
  Lines      224837   224837             
=========================================
- Hits       183505   183477     -28     
- Misses      41332    41360     +28     

@steviez steviez requested a review from brooksprumo January 31, 2024 01:55
Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for unifying this arg!

@steviez steviez merged commit b3ea62f into solana-labs:master Jan 31, 2024
35 checks passed
@steviez steviez deleted the lt_snapshot_arg branch January 31, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants