Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Moves create_and_canonicalize_directories() into accounts-db utils #34882

Conversation

brooksprumo
Copy link
Contributor

@brooksprumo brooksprumo commented Jan 22, 2024

Problem

We're trying to remove the fs-err crate. For more information, please refer to #34838.

snapshot_utils::create_and_canonicalize_directories() still uses fs-err, but doesn't need to. It all doesn't really have anything to do with snapshots.

Summary of Changes

  • Move create_and_canonicalize_directories() into accounts-db utils
  • Replace fs-err with std::fs
  • Update callers, and add more info to their error messages

@brooksprumo brooksprumo self-assigned this Jan 22, 2024
@brooksprumo brooksprumo force-pushed the errors/create_and_canonicalize_directories branch from 725fc81 to f74ce41 Compare January 22, 2024 19:41
@brooksprumo brooksprumo added the work in progress This isn't quite right yet label Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (a5c470d) 81.7% compared to head (28b5491) 81.6%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #34882     +/-   ##
=========================================
- Coverage    81.7%    81.6%   -0.2%     
=========================================
  Files         826      827      +1     
  Lines      223413   223810    +397     
=========================================
+ Hits       182614   182686     +72     
- Misses      40799    41124    +325     

@brooksprumo brooksprumo force-pushed the errors/create_and_canonicalize_directories branch from f74ce41 to 28b5491 Compare January 22, 2024 23:19
@brooksprumo brooksprumo removed the work in progress This isn't quite right yet label Jan 22, 2024
@brooksprumo brooksprumo marked this pull request as ready for review January 23, 2024 00:43
@brooksprumo brooksprumo requested a review from steviez January 23, 2024 00:44
@brooksprumo brooksprumo merged commit 8ff511e into solana-labs:master Jan 23, 2024
36 checks passed
@brooksprumo brooksprumo deleted the errors/create_and_canonicalize_directories branch January 23, 2024 14:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants