v1.16: pin ahash version #34645
Closed
v1.16: pin ahash version #34645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
removed
the
automerge
CriesofCarrots
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
It looks like they've yanked everything before v0.8.4 back to v0.4.1 😞
I don't love how many things in the Cargo.lock this touches, but I don't have a better suggestion to fix the build. I'm approving, but give Will or Trent a chance to weigh in before merging.
|
i would like to abandon this dependency entirely tkaitchuck/aHash@b583310#r136011618 i think this worked locally... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ci error on v1.16: https://buildkite.com/solana-labs/solana/builds/106239#018cd29e-8257-4530-9a36-ac08d70f88b3
Summary of Changes
pin ahash to 0.8.4.
(I thought I can only pin it to 0.8.3 but I failed 😢: https://buildkite.com/solana-labs/solana/builds/106258#018cd2c6-0e42-4cc8-8d43-94b1516e1d26. I haven't delved into it too deeply. If we feel pinning ahash 0.8.4 is too aggressive, I can spend more time on it.)