-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: split cargo-clippy into stable and nightly #34566
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The split code looks fine. Should probably put the mergify changes in here too, though, since you're changing the job names.
okay! updated! just had a quick look to those code. I guess they can be backported directly 🤞 |
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
* ci: split cargo-clippy into stable and nightly * ci: update mergify (cherry picked from commit 5247be1) # Conflicts: # .mergify.yml # scripts/cargo-clippy.sh
* ci: split cargo-clippy into stable and nightly * ci: update mergify (cherry picked from commit 5247be1) # Conflicts: # .mergify.yml # scripts/cargo-clippy.sh
…4566) (#34569) * ci: split cargo-clippy into stable and nightly (#34566) * ci: split cargo-clippy into stable and nightly * ci: update mergify (cherry picked from commit 5247be1) # Conflicts: # .mergify.yml # scripts/cargo-clippy.sh * fix conflict --------- Co-authored-by: Yihau Chen <[email protected]> Co-authored-by: yihau <[email protected]>
…4566) (#34568) * ci: split cargo-clippy into stable and nightly (#34566) * ci: split cargo-clippy into stable and nightly * ci: update mergify (cherry picked from commit 5247be1) # Conflicts: # .mergify.yml # scripts/cargo-clippy.sh * fix conflict * fix clippy rule --------- Co-authored-by: Yihau Chen <[email protected]> Co-authored-by: yihau <[email protected]>
Problem
context: https://discord.com/channels/428295358100013066/560503042458517505/1187442157326450780
Summary of Changes
btw, if we still feel this one too slow, I can split them into smaller pieces (but will be a little bit hardcoded)
or we need a better macos runner 😢