Derives Pod for tiered storage types #34414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34414 +/- ##
=========================================
- Coverage 81.9% 81.8% -0.1%
=========================================
Files 819 819
Lines 220984 220991 +7
=========================================
- Hits 181015 180984 -31
- Misses 39969 40007 +38 |
yhchiang-sol
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Related to #34121, we'd like to eliminate all undefined behavior in Tiered Storage w.r.t. reading and writing bytes from files/mmaps.
The bytemuck crate provides traits for guaranteeing data layout that ensures there will not be undefined behavior. Tiered Storage is missing some of those traits that would make UB go away.
Summary of Changes
Derive the appropriate bytemuck traits on the Tiered Storage types that are written to files. Also add constant asserts to ensure the invariants for Pod are not broken.