-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tokens: fix url clap arg name #34371
Conversation
I advocate for at least a v1.17 backport here since it fixes a regression and only touches a cli tool. My ego would like a v1.16 backport as well, but since that branch is almost EOL, I suppose it's not strictly necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah darn, these are the worst. The fix looks good!
Definitely a backport to 1.17 makes sense, and even a backport to 1.16 makes sense if people are still using solana-tokens
on that release. There's no impact on anything sensitive here. Are there any future 1.16 releases planned?
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
I'll find out! If so, I'll probably go ahead and tag this to be included. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34371 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 819 819
Lines 220915 220915
=======================================
+ Hits 180899 180915 +16
+ Misses 40016 40000 -16 |
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
Fix url clap arg name (cherry picked from commit e8945d2)
Fix url clap arg name (cherry picked from commit e8945d2)
tokens: fix url clap arg name (#34371) Fix url clap arg name (cherry picked from commit e8945d2) Co-authored-by: Tyera <[email protected]>
tokens: fix url clap arg name (#34371) Fix url clap arg name (cherry picked from commit e8945d2) Co-authored-by: Tyera <[email protected]>
Problem
solana-tokens
versions v1.16 and v1.17 aren't respecting the--url
arg passed with a command. This is because this change updated the name of the url clap arg (to be consistent withsolana-cli
and other tools), but neglected to also update the matches parser.Summary of Changes
Update arg name in matches parser
cc @tigarcia