Add _program suffix to directories of crates with _program suffix #3421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3421 +/- ##
========================================
- Coverage 79.7% 79.7% -0.1%
========================================
Files 146 146
Lines 23095 23095
========================================
- Hits 18417 18416 -1
- Misses 4678 4679 +1 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3421 +/- ##
========================================
- Coverage 79.7% 79.7% -0.1%
========================================
Files 146 146
Lines 23095 23095
========================================
- Hits 18417 18416 -1
- Misses 4678 4679 +1 |
alessandrod
pushed a commit
to alessandrod/solana
that referenced
this pull request
Nov 5, 2024
…olana-labs#3416) (solana-labs#3421) * CI: Re-enable downstream SPL jobs (solana-labs#3416) #### Problem The downstream SPL jobs were disabled in solana-labs#3414 because the crates weren't being patched properly. #### Summary of changes Since the crates are now being properly patched in solana-labs/solana-program-library#7434, re-enable those jobs! At the same time, remove the patch to bump the curve25519-dalek version. (cherry picked from commit f9af09c) # Conflicts: # .github/workflows/downstream-project-spl.yml * Fix merge conflict --------- Co-authored-by: Jon C <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
_programcrates are about to be stripped down to a single macro invocation, used just to create a dynamic library that can be deployed to the cluster. The crate that currently has an_apiprefix will be where all development is done. The current naming convention suggests the program crate would be where the action happens.Summary of Changes
Add _program suffix to all the dylib crates, which is what their Cargo.toml files already append to their respective crate names.