Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: Replaces .get(0) with .first() #34150

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

brooksprumo
Copy link
Contributor

Problem

There are nightly clippy warnings that will prevent upgrading our stable Rust version.

For this PR, it's this one: https://rust-lang.github.io/rust-clippy/master/index.html#/get(0)

Summary of Changes

Replaces .get(0) with .first().

@brooksprumo brooksprumo self-assigned this Nov 17, 2023
@brooksprumo brooksprumo marked this pull request as ready for review November 17, 2023 20:25
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #34150 (daa4c9d) into master (6c62ad7) will increase coverage by 0.0%.
Report is 1380 commits behind head on master.
The diff coverage is 90.9%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #34150      +/-   ##
==========================================
  Coverage    81.8%    81.9%              
==========================================
  Files         766      819      +53     
  Lines      209158   220127   +10969     
==========================================
+ Hits       171210   180331    +9121     
- Misses      37948    39796    +1848     

Copy link
Contributor

@bw-solana bw-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brooksprumo brooksprumo merged commit c585e54 into solana-labs:master Nov 17, 2023
32 checks passed
@brooksprumo brooksprumo deleted the clippy/first branch November 17, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants