Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system monitory: don't suggest query-only limits #34149

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

t-nelson
Copy link
Contributor

Problem

apparently quic uses cmsgs. net.core.optmem_max being specified with a value of 0 still prints a suggestion message, implying that the operator should tune it to zero. this disables cmsg support, breaks quic, prevents user tx receipt and results in leaders building vote-only blocks

Summary of Changes

  • add explicit "query-only" knob specification
  • don't print recommendations for query-only knobs

Copy link
Contributor

@jbiseda jbiseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #34149 (e372ed7) into master (6c62ad7) will increase coverage by 0.0%.
Report is 1378 commits behind head on master.
The diff coverage is 90.9%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #34149      +/-   ##
==========================================
  Coverage    81.8%    81.9%              
==========================================
  Files         766      818      +52     
  Lines      209158   220016   +10858     
==========================================
+ Hits       171210   180267    +9057     
- Misses      37948    39749    +1801     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants