Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses mmap for names in tiered storage #34127

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

brooksprumo
Copy link
Contributor

Problem

Mmap variables are used inside tiered storage in many places. Sometimes they are called mmap and sometimes they are called map. Since map already has a common, different meaning, we should (1) be consistent, and (2) prefer mmap.

Summary of Changes

Renames map to mmap.

@brooksprumo brooksprumo self-assigned this Nov 16, 2023
@brooksprumo brooksprumo marked this pull request as ready for review November 16, 2023 23:22
Copy link
Contributor

@yhchiang-sol yhchiang-sol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is also one thing in my mind. Thanks for picking this up!

@brooksprumo brooksprumo added the automerge Merge this Pull Request automatically once CI passes label Nov 16, 2023
@mergify mergify bot merged commit 07b0b9f into solana-labs:master Nov 16, 2023
33 checks passed
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #34127 (4588e51) into master (32993b2) will increase coverage by 0.0%.
Report is 1357 commits behind head on master.
The diff coverage is 90.9%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #34127      +/-   ##
==========================================
  Coverage    81.8%    81.9%              
==========================================
  Files         766      818      +52     
  Lines      209077   219939   +10862     
==========================================
+ Hits       171130   180207    +9077     
- Misses      37947    39732    +1785     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants