Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes filler accounts #34115

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

brooksprumo
Copy link
Contributor

Problem

Filler accounts were used to stress the accounts db subsystem, but the pop-net clusters now are used instead.

Summary of Changes

Since the filler accounts are basically a hack, and no longer required, remove them.

@brooksprumo brooksprumo added the work in progress This isn't quite right yet label Nov 16, 2023
@brooksprumo brooksprumo self-assigned this Nov 16, 2023
@brooksprumo brooksprumo removed the work in progress This isn't quite right yet label Nov 16, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #34115 (425e874) into master (32993b2) will increase coverage by 0.1%.
Report is 1355 commits behind head on master.
The diff coverage is 90.9%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #34115      +/-   ##
==========================================
+ Coverage    81.8%    81.9%    +0.1%     
==========================================
  Files         766      817      +51     
  Lines      209077   219725   +10648     
==========================================
+ Hits       171130   180125    +8995     
- Misses      37947    39600    +1653     

@brooksprumo brooksprumo marked this pull request as ready for review November 16, 2023 22:13
Copy link
Contributor

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I imagine it is ok to just delete cli args and not deprecate. I seriously doubt ANYONE was using these.

@brooksprumo brooksprumo merged commit e02f25d into solana-labs:master Nov 20, 2023
32 checks passed
@brooksprumo brooksprumo deleted the filler-accounts/remove branch November 20, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants