This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
cli: solana-tokens, validate inputs gracefully #33926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norwnd
commented
Oct 30, 2023
norwnd
commented
Oct 30, 2023
norwnd
commented
Oct 30, 2023
norwnd
force-pushed
the
cli-solana-tokens-validate-inputs-gracefully
branch
from
30dfbaa to
b9c5a07
Compare
|
Fixed couple other "typos" too, thanks for reviewing @CriesofCarrots ! Should be ready for another round. |
There was a problem hiding this comment.
This is looking really close! A couple small suggestions, and then please rebase on #33937 and update those helpers in spl_token.rs.
norwnd
force-pushed
the
cli-solana-tokens-validate-inputs-gracefully
branch
from
b9c5a07 to
67cc4cd
Compare
added 6 commits
November 1, 2023 22:07
norwnd
force-pushed
the
cli-solana-tokens-validate-inputs-gracefully
branch
from
67cc4cd to
a77649e
Compare
|
Ah, |
Apologies for this one, I need some time to get used to Rust tooling. Fixed, hopefully. |
Codecov Report
@@ Coverage Diff @@
## master #33926 +/- ##
========================================
Coverage 81.9% 81.9%
========================================
Files 809 809
Lines 218250 218396 +146
========================================
+ Hits 178793 178946 +153
+ Misses 39457 39450 -7 |
CriesofCarrots
approved these changes
Nov 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Resolves #16489.
Summary of Changes
Hey @CriesofCarrots, I took this task on to get a bit more comfortable with Rust, lets see if it fits what you had in mind.