Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multinode-demo scripts support --block-production-method arg #33891

Merged

Conversation

apfitzge
Copy link
Contributor

Problem

Summary of Changes

  • Add block-production-method support to bootstrap-validator.sh and validator.sh

Fixes #

@apfitzge
Copy link
Contributor Author

Appears that remote-node.sh already supports arbitrary extra node arguments, which are then passed to one of these two scripts. So I think we should be goo there.

@apfitzge apfitzge requested a review from yihau October 27, 2023 04:07
@apfitzge apfitzge marked this pull request as ready for review October 27, 2023 04:07
Copy link
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪖

btw, if we need this one to happen when we call net/net.sh as well. we might need to add some changes to here

solana/net/net.sh

Lines 968 to 981 in 0873705

elif [[ $1 = --client-type ]]; then
clientType=$2
case "$clientType" in
thin-client|tpu-client|rpc-client)
;;
*)
echo "Unexpected client type: \"$clientType\""
exit 1
;;
esac
shift 2
else
usage "Unknown long option: $1"
fi

@apfitzge apfitzge merged commit b2cec5a into solana-labs:master Oct 31, 2023
16 checks passed
@apfitzge apfitzge deleted the block-production-method-scripts branch October 31, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants