zk-token-sdk: Fix incorrect mention of OsRng in docs #33774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
reviewed
Oct 19, 2023
ripatel-fd
force-pushed
the
ripatel/zero-knowledge-token-sdk-sigma-proof-batched-grouped-ciphertext-2-handles-validity-proof-verify-incorrect-documentation
branch
from
5cbca50 to
939900f
Compare
|
@joncinque Done. I'm glad it was just a bug in the documentation 🎉 |
|
Merging without buildkite CI since there's no functional change |
ripatel-fd
deleted the
ripatel/zero-knowledge-token-sdk-sigma-proof-batched-grouped-ciphertext-2-handles-validity-proof-verify-incorrect-documentation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The documentation of BatchedGroupedCiphertext2HandlesValidityProof::verify mentions use of
OsRng.This function is used in Zero-Knowledge Token Proof Program instruction processing. Therefore use of OsRng would break consensus.
Summary of Changes
It looks like the problematic comment was copy pasted from somewhere else as is not valid. Please double check that this is actually the case.
Removes the problematic comment.
Fixes #