Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returns AccountHash from get_filler_account() #33758

Merged

Conversation

brooksprumo
Copy link
Contributor

@brooksprumo brooksprumo commented Oct 18, 2023

Problem

AccountsDb::get_filler_account() returns the account's hash as a bare Hash. We have AccountHash now, and should use that instead.

Summary of Changes

Return AccountHash from get_filler_account().

@brooksprumo brooksprumo added the noCI Suppress CI on this Pull Request label Oct 18, 2023
@brooksprumo brooksprumo self-assigned this Oct 18, 2023
@brooksprumo brooksprumo force-pushed the account-hash/get_filler_account branch from eec241c to 83d3494 Compare October 18, 2023 22:59
@brooksprumo brooksprumo added CI Pull Request is ready to enter CI and removed noCI Suppress CI on this Pull Request labels Oct 18, 2023
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Oct 18, 2023
@brooksprumo brooksprumo marked this pull request as ready for review October 18, 2023 23:13
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #33758 (83d3494) into master (93d882f) will decrease coverage by 0.1%.
Report is 2 commits behind head on master.
The diff coverage is 89.7%.

@@            Coverage Diff            @@
##           master   #33758     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         806      806             
  Lines      217908   217911      +3     
=========================================
- Hits       178270   178267      -3     
- Misses      39638    39644      +6     

Copy link
Contributor

@yhchiang-sol yhchiang-sol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@brooksprumo brooksprumo merged commit 0fcc0a0 into solana-labs:master Oct 19, 2023
16 checks passed
@brooksprumo brooksprumo deleted the account-hash/get_filler_account branch October 19, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants