Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant pubkey update record #33722

Merged

Conversation

gregcusack
Copy link
Contributor

Problem

a validator uses the pubkey of the sender of a PullResponse to update the sender's liveliness in itsCrds::table. But this is redundant because eventually the sender of the PullResponse will be the origin of some CrdsValue that the validator will receive. So the validator is essentially updating the liveliness twice.

Summary of Changes

Eliminated updating the sender of a PullResponse's liveliness

Fixes #

behzadnouri
behzadnouri previously approved these changes Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #33722 (f4ee1ba) into master (69495f4) will increase coverage by 0.0%.
Report is 1 commits behind head on master.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           master   #33722   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         806      806           
  Lines      217854   217851    -3     
=======================================
+ Hits       178213   178248   +35     
+ Misses      39641    39603   -38     

@behzadnouri behzadnouri added the v1.17 PRs that should be backported to v1.17 label Oct 17, 2023
@gregcusack gregcusack merged commit 6efc7ec into solana-labs:master Oct 17, 2023
16 checks passed
@gregcusack gregcusack deleted the rm-redundant-pubkey-update-record branch October 17, 2023 17:34
mergify bot pushed a commit that referenced this pull request Oct 17, 2023
* remove redundant pubkey update record

* from became unused, so removed from all process_pull_response() calls

(cherry picked from commit 6efc7ec)
mergify bot added a commit that referenced this pull request Oct 17, 2023
…3735)

remove redundant pubkey update record (#33722)

* remove redundant pubkey update record

* from became unused, so removed from all process_pull_response() calls

(cherry picked from commit 6efc7ec)

Co-authored-by: Greg Cusack <[email protected]>
behzadnouri added a commit to behzadnouri/solana that referenced this pull request Oct 17, 2023
Following:
solana-labs#33722
from pubkey in PullResponse is no longer used in processing
pull-responses and as a result the code can be simplified.
behzadnouri added a commit to behzadnouri/solana that referenced this pull request Oct 17, 2023
Following:
solana-labs#33722
from pubkey in PullResponse is no longer used in processing
pull-responses and as a result the code can be simplified.
behzadnouri added a commit that referenced this pull request Oct 18, 2023
Following:
#33722
from pubkey in PullResponse is no longer used in processing
pull-responses and so the code can be simplified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.17 PRs that should be backported to v1.17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants