Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TieredStorage] Footer test for HotStorageReader #33718

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

yhchiang-sol
Copy link
Contributor

Problem

HotStorageReader currently doesn't have a test that covers its footer.

Summary of Changes

This PR includes a test for HotStorageReader that verifies the footer.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #33718 (f5f646b) into master (d948e5b) will increase coverage by 0.0%.
Report is 1 commits behind head on master.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           master   #33718   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         806      806           
  Lines      217851   217869   +18     
=======================================
+ Hits       178204   178232   +28     
+ Misses      39647    39637   -10     

Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@yhchiang-sol yhchiang-sol merged commit 0b05e8d into solana-labs:master Oct 17, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants