Fold noisy metric into struct of metrics that is reported every 10s

[steviez]

Problem

Noisy metric as reported by #33610

Summary of Changes

Move the individual datapoint into a struct of other metrics that are collected + reported every 10s

Fixes #33610

[codecov]

Codecov Report

Merging #33635 (1f4ddcc) into master (982d29c) will increase coverage by 0.0%.
Report is 1 commits behind head on master.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           master   #33635   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         806      806           
  Lines      217499   217503    +4     
=======================================
+ Hits       178019   178031   +12     
+ Misses      39480    39472    -8     

[CriesofCarrots]

Sorry for missing this one in review! Lgtm.

Another pubsub metric we might consider quieting is this one. Seems like with a fairly standard set of subscriptions, it will notify every slot.
I think we also report a metric on every subscription added or dropped (in this file), which might be kind of annoying on a busy RPC node, though no one has complained...?

[steviez]

Another pubsub metric we might consider quieting is this one. Seems like with a fairly standard set of subscriptions, it will notify every slot.

Oof yeah, I see a good amount of inc_new_counter_info! in there as well. Definitely some cleanup to be done, will save that for a separate PR.

I think we also report a metric on every subscription added or dropped (in this file), which might be kind of annoying on a busy RPC node, though no one has complained...?

Yeah, could be another contender