v1.17: Deprecate bz2/gzip/none/tar snapshot compression types (backport of #33484) #33492
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
These options are now disallowed on the command line for solana-validator and solana-ledger-tool, which effectively means no more snapshots will be created with this types in normal usecases. However, support for reading the deprecated types is still in place. (cherry picked from commit 73e9e6d)
steviez
force-pushed
the
mergify/bp/v1.17/pr-33484
branch
from
59585c4 to
533ae74
Compare
|
Force pushed to rebase on top of v1.17 branch |
Codecov Report
@@ Coverage Diff @@
## v1.17 #33492 +/- ##
=========================================
- Coverage 81.7% 81.7% -0.1%
=========================================
Files 802 802
Lines 217786 217777 -9
=========================================
- Hits 178110 178090 -20
- Misses 39676 39687 +11 |
|
@mvines & @brooksprumo - Me adding the |
There was a problem hiding this comment.
@mvines & @brooksprumo - Me adding the
v1.17label is my inherent support for backporting this. What do you all think; technically, I missed the v1.17 cut by a day but I think this is a low-risk change and will get rid of something that has been a support headache for a while
Yeah, I think it makes sense to have this in v1.17.
|
Given that Brooks already agrees with pushing this into v1.17, I'm going to take the "ask for forgiveness instead of permission" approach in regards to mvines + willhickey and assume they are fine with this too |
This is an automatic backport of pull request #33484 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com