Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clap-v3-utils] Deprecate signer validation and update parsing for clap-v3 #33478

Closed
wants to merge 17 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
make SignerSource implement Clone
samkim-crypto committed Oct 15, 2023
commit 703c5a5c5427fec5f9c407a64b33634536964574
3 changes: 2 additions & 1 deletion clap-v3-utils/src/keypair.rs
Original file line number Diff line number Diff line change
@@ -371,7 +371,7 @@ impl DefaultSigner {
}
}

#[derive(Debug)]
#[derive(Debug, Clone)]
pub(crate) struct SignerSource {
pub kind: SignerSourceKind,
pub derivation_path: Option<DerivationPath>,
@@ -402,6 +402,7 @@ const SIGNER_SOURCE_USB: &str = "usb";
const SIGNER_SOURCE_STDIN: &str = "stdin";
const SIGNER_SOURCE_PUBKEY: &str = "pubkey";

#[derive(Clone)]
pub(crate) enum SignerSourceKind {
Prompt,
Filepath(String),
2 changes: 1 addition & 1 deletion remote-wallet/src/locator.rs
Original file line number Diff line number Diff line change
@@ -87,7 +87,7 @@ impl From<Infallible> for LocatorError {
}
}

#[derive(Debug, PartialEq, Eq)]
#[derive(Clone, Debug, PartialEq, Eq)]
pub struct Locator {
pub manufacturer: Manufacturer,
pub pubkey: Option<Pubkey>,