Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sort timer out of loop #33448

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Conversation

HaoranYi
Copy link
Contributor

Problem

Since slot_storage sort scan is sequential, there is no need to accumulate the scan timing with atomic u64.

Summary of Changes

Use measure_us to measure slot storage scan timing.

Fixes #

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #33448 (12ab626) into master (cc4e928) will increase coverage by 0.0%.
Report is 1 commits behind head on master.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           master   #33448   +/-   ##
=======================================
  Coverage    81.9%    81.9%           
=======================================
  Files         799      799           
  Lines      217340   217335    -5     
=======================================
+ Hits       178144   178145    +1     
+ Misses      39196    39190    -6     

Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, thanks!

@HaoranYi HaoranYi merged commit 6ea5128 into solana-labs:master Sep 29, 2023
16 checks passed
@HaoranYi HaoranYi deleted the sep_28_2023 branch September 29, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants