Reloads deployments with environments.program_runtime_v1

[Lichtso]

Problem

Quoting @pgarg66:

In deploy_program macro we are creating a new instance of runtime environment:

solana/programs/bpf_loader/src/lib.rs

Line 119 in ce63640

let program_runtime_environment = create_program_runtime_environment_v1(

This means that the cached program will get pruned here:

solana/program-runtime/src/loaded_programs.rs

Line 497 in ce63640

if Arc::ptr_eq(

Also, reject_deployment_of_broken_elfs is false when the environment is created in bank.rs while it is true when it is created in deploy_program(). This is to retain some old behavior for previously deployed program (so that bank can continue to load them), but reject the broken elf for any new program deployments.
For loader-v4 we don't have the above restriction (i.e. no old deployed programs which could have broken elfs). So, I think it makes sense to reuse the runtime environment instance from the cache, instead of creating a new one.

Summary of Changes

Instead of loading the deployed program with the special deployment environment and storing it in the cache:

• First only parse the ELF, and verify it against the special deployment environment
• But then reload and compile it (without another verification) against the current environment and store that in the cache

[pgarg66]

LGTM, will approve once CI passes.

[dmakarov]

LGTM

[codecov]

Codecov Report

Merging #33412 (0c4ad81) into master (ddd0297) will decrease coverage by 0.1%.
The diff coverage is 50.0%.

@@            Coverage Diff            @@
##           master   #33412     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         798      798             
  Lines      217101   217109      +8     
=========================================
- Hits       178015   177983     -32     
- Misses      39086    39126     +40