reduce WARN logging to only necessary scenario #33408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33408 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 798 798
Lines 216974 216974
=======================================
+ Hits 177902 177905 +3
+ Misses 39072 39069 -3 |
CriesofCarrots
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
This looks okay to me, but I don't have the complete context from the original changeset. It might be a good idea to have one of your reviewers from that PR approve this.
Please backport to v1.16 to prevent spamming the (soon to be) stable TestValidator with these warnings.
mergify bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
(cherry picked from commit cc4e928)
mergify bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
(cherry picked from commit cc4e928)
This was referenced Sep 28, 2023
tao-stones
added a commit
that referenced
this pull request
Sep 28, 2023
…3408) (#33444) reduce WARN logging to only necessary scenario (#33408) (cherry picked from commit cc4e928) Co-authored-by: Tao Zhu <[email protected]>
tao-stones
added a commit
that referenced
this pull request
Sep 28, 2023
…3408) (#33445) reduce WARN logging to only necessary scenario (#33408) (cherry picked from commit cc4e928) Co-authored-by: Tao Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A WARN log being excessively triggered by vote-only slots. It was meant to log an unlikely event when duplicated bank had prioritized TXs but the confirmed bank had none. It is not entirely impossible, but maybe something worth looking into, hence logging.
Summary of Changes
Fixes #